Update README.md - #2
Merged
Merged
Conversation
lee-orr
approved these changes
Aug 31, 2023
lee-orr
left a comment
lee-orr
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Just to comment on the "no sudo" thing - it's more about needing sudo to exist in order for the install to succeed. So yes - it runs in root, but the other tinygo feature wouldn't work on images that don't have sudo installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr would:
root, right? so i dont think "no sudo" means much 🤷♀️ i could be wrong tho idk.devcontainer-feature.jsonto match readmeversion: "0.29.0"examplescreenshot before/after
@lee-orr this is your feature to merge/notmerge; I'm just some random contributor! 🤣